lkml.org 
[lkml]   [2017]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRE: [PATCH v3 6/8] PM / devfreq: Remove unneeded conditional statement
    From
    Date
    > The commit 0ec09ac2cebe9 ("PM / devfreq: Set the freq_table of devfreq
    > device") initializes the freq_table array of each devfreq device always.
    > In result, it is unneeded to check whether profile->freq_table is NULL
    > or not.
    >
    > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
    > ---
    > drivers/devfreq/devfreq.c | 7 +++----
    > 1 file changed, 3 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
    > index 3b9662ffe603..b28810cae7ee 100644
    > --- a/drivers/devfreq/devfreq.c
    > +++ b/drivers/devfreq/devfreq.c
    > @@ -315,10 +315,9 @@ int update_devfreq(struct devfreq *devfreq)
    > freqs.new = freq;
    > devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
    >
    > - if (devfreq->profile->freq_table)
    > - if (devfreq_update_status(devfreq, freq))
    > - dev_err(&devfreq->dev,
    > - "Couldn't update frequency transition information.\n");
    > + if (devfreq_update_status(devfreq, freq))
    > + dev_err(&devfreq->dev,
    > + "Couldn't update frequency transition information.\n");

    To make this commit really safe,
    in this commit, please make devfreq_set_freq_table to return error
    and let add_device fails when it returns error.

    In the current code, we cannot guarantee that there will be
    freq_table and trans_table available when it hits this line.

    Cheers,
    MyungJoo

    >
    > devfreq->previous_freq = freq;
    > return err;
    > --
    > 1.9.1

    \
     
     \ /
      Last update: 2017-10-11 13:37    [W:4.059 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site