Messages in this thread | | | Subject | Re: [PATCH v2] nvme-pci: Use PCI bus address for data/queues in CMB | From | Sagi Grimberg <> | Date | Wed, 11 Oct 2017 13:00:18 +0300 |
| |
> --- > From b78f4164881125c4fecfdb87878d0120b2177c53 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig <hch@lst.de> > Date: Sun, 1 Oct 2017 09:37:35 +0200 > Subject: nvme-pci: Use PCI bus address for data/queues in CMB > > Currently, NVMe PCI host driver is programming CMB dma address as > I/O SQs addresses. This results in failures on systems where 1:1 > outbound mapping is not used (example Broadcom iProc SOCs) because > CMB BAR will be progammed with PCI bus address but NVMe PCI EP will > try to access CMB using dma address. > > To have CMB working on systems without 1:1 outbound mapping, we > program PCI bus address for I/O SQs instead of dma address. This > approach will work on systems with/without 1:1 outbound mapping. > > Based on a report and previous patch from Abhishek Shah. > > Fixes: 8ffaadf7 ("NVMe: Use CMB for the IO SQes if available") > Cc: stable@vger.kernel.org > Reported-by: Abhishek Shah <abhishek.shah@broadcom.com> > Signed-off-by: Christoph Hellwig <hch@lst.de>
This looks good,
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
| |