lkml.org 
[lkml]   [2017]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 127/160] arm64: Ensure the instruction emulation is ready for userspace
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Suzuki K Poulose <suzuki.poulose@arm.com>

    commit c0d8832e78cbfd4a64b7112e34920af4b0b0e60e upstream.

    We trap and emulate some instructions (e.g, mrs, deprecated instructions)
    for the userspace. However the handlers for these are registered as
    late_initcalls and the userspace could be up and running from the initramfs
    by that time (with populate_rootfs, which is a rootfs_initcall()). This
    could cause problems for the early applications ending up in failure
    like :

    [ 11.152061] modprobe[93]: undefined instruction: pc=0000ffff8ca48ff4

    This patch promotes the specific calls to core_initcalls, which are
    guaranteed to be completed before we hit userspace.

    Cc: Dave Martin <dave.martin@arm.com>
    Cc: Matthias Brugger <mbrugger@suse.com>
    Cc: James Morse <james.morse@arm.com>
    Reported-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm64/kernel/armv8_deprecated.c | 2 +-
    arch/arm64/kernel/cpufeature.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/arm64/kernel/armv8_deprecated.c
    +++ b/arch/arm64/kernel/armv8_deprecated.c
    @@ -649,4 +649,4 @@ static int __init armv8_deprecated_init(
    return 0;
    }

    -late_initcall(armv8_deprecated_init);
    +core_initcall(armv8_deprecated_init);
    --- a/arch/arm64/kernel/cpufeature.c
    +++ b/arch/arm64/kernel/cpufeature.c
    @@ -1294,4 +1294,4 @@ static int __init enable_mrs_emulation(v
    return 0;
    }

    -late_initcall(enable_mrs_emulation);
    +core_initcall(enable_mrs_emulation);

    \
     
     \ /
      Last update: 2017-10-10 22:07    [W:4.251 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site