Messages in this thread | | | Subject | Re: [PATCH v2] clk: qcom: gdsc: Fix handling of hw control enable/disable | From | Stanimir Varbanov <> | Date | Thu, 26 Jan 2017 23:31:03 +0200 |
| |
Hi,
Thanks for the patch!
On 23.01.2017 06:26, Rajendra Nayak wrote: > Once a gdsc is brought in and out of HW control, there is a > power down and up cycle which can take upto 1us. Polling on > the gdsc status immediately after the hw control enable/disable > can mislead software/firmware to belive the gdsc is already either on > or off, while its yet to complete the power cycle. > To avoid this add a 1us delay post a enable/disable of HW control > mode. > > Also after the HW control mode is disabled, poll on the status to > check gdsc status reflects its 'on' before force disabling it > in software. > > Reported-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > --- > drivers/clk/qcom/gdsc.c | 58 ++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 45 insertions(+), 13 deletions(-)
Reviewed and Tested-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
regards, Stan
| |