Messages in this thread | | | Date | Mon, 2 Jan 2017 09:47:30 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] mm: cma: print allocation failure reason and bitmap status |
| |
On Sun 01-01-17 22:59:40, Michal Nazarewicz wrote: [...] > Actually, Linux style is more like: > > #ifdef CONFIG_CMA_DEBUG > static void cma_debug_show_areas() > { > … > } > #else > static inline void cma_debug_show_areas() { } > #endif
yes, we usually do that when the function is externally visible. Inline ifdef for static functions saves few lines. Not that it would matter much though. -- Michal Hocko SUSE Labs
| |