lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] rxrpc: remove duplicate 'error' variable
Date
On Tuesday, September 6, 2016 2:34:02 PM CEST David Howells wrote:
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > The rxrpc_process_call function has debug code to print a failure code,
> > but instead of printing the code from the rxrpc_call structure, it
> > prints an uninitialized variable:
> >
> > net/rxrpc/call_event.c: In function 'rxrpc_process_call':
> > net/rxrpc/call_event.c:879:58: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >
> > This removes the extraneous variable and prints the correct
> > code instead.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: f5c17aaeb2ae ("rxrpc: Calls should only have one terminal state")
>
> I've already posted a fix and it's waiting on DaveM.
>
> https://patchwork.ozlabs.org/patch/665550/
>
> http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-rewrite&id=00b5407e427ac2588a2496b92035a94602b3cd1b

Ok, good. At least I'm glad my patch is correct this time (being identical
to yours).

Arnd

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.049 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site