lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls
On Sat, 03 Sep 2016 00:44:02 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote:
> > - The guide currently says to pad the structure to a multiple of
> > 64-bits. This is not necessary in cases where the structure contains
> > no 64-bit types. Clarify this concept to avoid unnecessary padding.
> > - When using __u64 to hold user pointers, blindly trying to do a cast to
> > a void __user * may generate a warning on 32-bit systems about a cast
> > from an integer to a pointer of different size. There is a macro to
> > deal with this which hides an ugly double cast. Add a reference to
> > this macro.
> >
> > Signed-off-by: Laura Abbott <labbott@redhat.com>
> >
>
> Looks good to me,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Applied to the docs tree, thanks.

jon

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.034 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site