lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node
    On Tue, Sep 06, 2016 at 04:55:55PM +0800, Jisheng Zhang wrote:
    > This patch fixes the following DTC warning with W=1:
    >
    > "Node /soc has a reg or ranges property, but no unit name"
    >
    > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>

    The node is only compatible with simple-bus, and so shouldn't have a
    reg.

    Why not remove the reg?

    Mark

    > ---
    > arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
    > index 099ad93..2d6f91f 100644
    > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
    > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
    > @@ -134,7 +134,7 @@
    > <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
    > };
    >
    > - soc {
    > + soc@f7000000 {
    > compatible = "simple-bus";
    > #address-cells = <1>;
    > #size-cells = <1>;
    > --
    > 2.9.3
    >

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:3.549 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site