Messages in this thread | | | Date | Tue, 6 Sep 2016 11:12:24 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel |
| |
On Mon, Sep 05, 2016 at 10:02:48PM +0200, Maxime Ripard wrote: > Hi, > > On Mon, Sep 05, 2016 at 01:03:03AM +0800, Icenowy Zheng wrote: > > Hi Everyone, > > > > 01.09.2016, 23:40, "Maxime Ripard" <maxime.ripard@free-electrons.com>: > > > The SinA33 has an unidentified panel. Add the timings for it under a new > > > compatible. > > > > > > > > Excuse me... > > I will ask a question which is not fully related to the patch here... > > If I want to add a generic panel for Q8 tablets, what should it be called? > > "allwinner,q8-lcd-panel-800x480"? > > I guess it's more of a question for Thierry, but it seems like the > trend is to put the diagonal rather than the resolution in the > compatibles.
Compatible strings should contain the model number of the panel. There is no such thing as a "generic panel for Q8 tablets".
Also, how is it that these panels are unidentified? Has nobody tried to open them up and look at the panel to find a model number?
Thierry [unhandled content-type:application/pgp-signature] | |