lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 0/4] tools lib traceevent: Install fixes
Em Tue, Aug 02, 2016 at 11:14:11PM +0900, Namhyung Kim escreveu:
> On Tue, Aug 02, 2016 at 04:01:44PM +0200, Jiri Olsa wrote:
> > On Tue, Aug 02, 2016 at 09:48:23AM -0400, Steven Rostedt wrote:
> >
> > SNIP
> >
> > > > >
> > > > >
> > > > > Also I think it'd be better for libtraceevent has dependency to libdl
> > > > > explicitly so that we can get rid of -ldl at the end.
> > > >
> > > > agreed, I'll queue your patch if v2 is needed
> > > >
> > >
> > > BTW, before we start making this ready for their own libraries, I'd
> > > like to make some changes with the naming convention. Mainly with
> > > event_format and format_field.
> > >
> > > Perhaps we should change them to pevent_event and pevent_field?
> >
> > right, it does not have any global prefix for public symbols
> >
> > I'd actualy expect something like 'traceevent_',
> > but 'pevent' is ok as well I guess
>
> The 'pevent' prefix would be more consistent to similar APIs IMHO.
>
> Maybe it's worth splitting public header and internal header files?

I'd suggest exporting just what is already used by tools, exposing more
as the need arises.

- Arnaldo

\
 
 \ /
  Last update: 2016-08-02 17:01    [W:1.050 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site