lkml.org 
[lkml]   [2016]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nvme-rdma: initialize ret to zero to avoid returning garbage
From
Date


On 16/08/16 11:24, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ret is not initialized so it contains garbage. Ensure garbage
> is not returned by initializing rc to 0.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/nvme/host/rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 8d2875b..9c69393 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1319,7 +1319,7 @@ out_destroy_queue_ib:
> static int nvme_rdma_device_unplug(struct nvme_rdma_queue *queue)
> {
> struct nvme_rdma_ctrl *ctrl = queue->ctrl;
> - int ret;
> + int ret = 0;
>
> /* Own the controller deletion */
> if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_DELETING))
>

Applied for the next round of rc fixes.

Thanks Colin.

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.048 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site