| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.6 084/203] Revert "HID: multitouch: enable palm rejection if device implements confidence usage" | Date | Mon, 25 Jul 2016 13:54:59 -0700 |
| |
4.6-stable review patch. If anyone has any objections, please let me know.
------------------
From: Allen Hung <allen_hung@dell.com>
commit 62630ea768869beeb1e514b0bf5607a0c9b93d12 upstream.
This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection if device implements confidence usage")
The commit enables palm rejection for Win8 Precision Touchpad devices but the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very properly. This quirk is originally designed for some WIn7 touchscreens. Use of this for a Win8 Precision Touchpad will cause unexpected pointer jumping problem.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3 Signed-off-by: Allen Hung <allen_hung@dell.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/hid/hid-multitouch.c | 5 ----- 1 file changed, 5 deletions(-)
--- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct mt_store_field(usage, td, hi); return 1; case HID_DG_CONFIDENCE: - if (cls->name == MT_CLS_WIN_8 && - field->application == HID_DG_TOUCHPAD) { - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; - cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; - } mt_store_field(usage, td, hi); return 1; case HID_DG_TIPSWITCH:
|