Messages in this thread Patch in this message | | | Subject | [PATCH] staging: rtl8188eu: Delete an unnecessary check before the function call "vfree" | From | SF Markus Elfring <> | Date | Mon, 25 Jul 2016 22:54:22 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 25 Jul 2016 22:20:24 +0200
The vfree() function performs also input parameter validation. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c index e0a5567..39ffb46 100644 --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c @@ -252,10 +252,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) pxmitbuf++; } - if (pxmitpriv->pallocated_xmit_extbuf) { - vfree(pxmitpriv->pallocated_xmit_extbuf); - } - + vfree(pxmitpriv->pallocated_xmit_extbuf); rtw_free_hwxmits(padapter); mutex_destroy(&pxmitpriv->ack_tx_mutex); -- 2.9.2
| |