Messages in this thread | | | Date | Mon, 25 Jul 2016 22:45:16 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise |
| |
> - else if (resp->i2c_status & EC_I2C_STATUS_ERROR) > + else if (resp->i2c_status & EC_I2C_STATUS_NAK) > + return -ENXIO; > + else if (resp->i2c_status) > return -EREMOTEIO;
Since you mentioned Documentation/i2c/fault-codes already: -EIO?
> > /* Other side could send us back fewer messages, but not more */ > @@ -223,7 +225,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], > > result = ec_i2c_parse_response(msg->data, i2c_msgs, &num); > if (result < 0) { > - dev_err(dev, "Error parsing EC i2c message %d\n", result); > + dev_dbg(dev, "Error parsing EC i2c message %d\n", result);
For me, this message can go entirely, but I'll leave this up to you.
[unhandled content-type:application/pgp-signature]
| |