Messages in this thread | | | Date | Mon, 25 Jul 2016 21:32:01 +0200 | From | walter harms <> | Subject | Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() |
| |
Am 25.07.2016 21:17, schrieb Lino Sanfilippo: >> >> - if (strncasecmp(buff, "RSSI", length) == 0) { >> + if (strncasecmp(buff, "RSSI", 0) == 0) { >> + s8 rssi; >> + > > Um, please think a second about if it makes any sense at all to compare > zero chars of two strings. > > Lino
also: the switch has only one case and default.
re, wh
| |