lkml.org 
[lkml]   [2016]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

Hello,

On Mon, 25 Jul 2016, 吉藤英明 wrote:

> OK, following blocks are "no-op" and we will get same result.
>
> Well, please do not try changing several things at the same time and
> you could say:
>
> if (ladder == neigh->ha && new == NUD_STALE &&
> !(flags & NUD_UPDATE_F_ADMIN))
> new = old;

OK, lets do it with 2 patches then.

Chunhui He, can you modify your patch to delete the
both lines and explain that we prefer to resolve the
remote address, even while remote packets try to set NUD_STALE
state. If your patch is accepted, I'll post second patch that
adds the line with the ADMIN check. As result, the code will
look like the example from Yoshifuji Hideaki above.

Regards

--
Julian Anastasov <ja@ssi.bg>
\
 
 \ /
  Last update: 2016-07-25 21:41    [W:0.034 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site