lkml.org 
[lkml]   [2016]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] coresight: tmc: Delete an unnecessary check before the function call "kfree"
    On 23 July 2016 at 12:08, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sat, 23 Jul 2016 20:04:09 +0200
    >
    > The kfree() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
    > index e68289b..5fa49c4 100644
    > --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
    > +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
    > @@ -168,7 +168,7 @@ out:
    > spin_unlock_irqrestore(&drvdata->spinlock, flags);
    >
    > /* Free memory outside the spinlock if need be */
    > - if (!used && buf)
    > + if (!used)
    > kfree(buf);
    >
    > if (!ret)
    > --
    > 2.9.2
    >

    Applied - thanks.
    Mathieu

    \
     
     \ /
      Last update: 2016-07-25 19:21    [W:4.014 / U:1.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site