lkml.org 
[lkml]   [2016]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP
From
Date


On 13/07/2016 11:21, Yang Zhang wrote:
>>
>> +static int handle_desc(struct kvm_vcpu *vcpu)
>> +{
>> + WARN_ON(!(vcpu->arch.cr4 & X86_CR4_UMIP));
>
> I think WARN_ON is too heavy since a malicious guest may trigger it always.

I missed this---how so? Setting the bit is under "if ((cr4 &
X86_CR4_UMIP) && !boot_cpu_has(X86_FEATURE_UMIP))".

Paolo

\
 
 \ /
  Last update: 2016-07-13 12:01    [W:0.200 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site