lkml.org 
[lkml]   [2016]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments
On Wed, Jun 08, 2016 at 12:03:24AM +0200, Pali Rohár wrote:
> On Thursday 02 June 2016 12:41:42 Michał Kępień wrote:
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > My guess is that Darren won't let you off without at least a short
> > commit message.
>
> I have no idea what else to write. I think that description is enough.

There is always something. For example, why? See Documentation/SubmittingPatches
section "14) The canonical patch format" for an explanation.

"Traceability" of changes is important. If it's worth preparing the patch, it's
worth documenting why.

--
Darren Hart
Intel Open Source Technology Center

\
 
 \ /
  Last update: 2016-06-08 22:01    [W:0.054 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site