lkml.org 
[lkml]   [2016]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] dmaengine: vdma: Add 64 bit addressing support for the axi dma
On Wed, May 18, 2016 at 01:17:32PM +0530, Kedareswara rao Appana wrote:
> + if (chan->cyclic) {
> + if (chan->ext_addr)
> + dma_writeq(chan, XILINX_DMA_REG_TAILDESC,
> + chan->cyclic_seg_v->phys);
> + else
> + dma_ctrl_write(chan, XILINX_DMA_REG_TAILDESC,
> + chan->cyclic_seg_v->phys);
> + } else {
> + if (chan->ext_addr)
> + dma_writeq(chan, XILINX_DMA_REG_TAILDESC,
> + tail_segment->phys);
> + else
> + dma_ctrl_write(chan, XILINX_DMA_REG_TAILDESC,
> + tail_segment->phys);

this looks ugly and repeated few times. Why not have xilinx_write() which
does either dma_writeq or dma_ctrl_write based on channel..

> + if (chan->ext_addr) {
> + hw->buf_addr = lower_32_bits(buf_addr +
> + sg_used + (period_len * i));
> + hw->buf_addr_msb = upper_32_bits(buf_addr +
> + sg_used + (period_len * i));
> + } else {
> + hw->buf_addr = buf_addr + sg_used +
> + (period_len * i);
> + }

similar wrapper here would make code more readable

--
~Vinod

\
 
 \ /
  Last update: 2016-06-07 08:21    [W:0.082 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site