Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 20 Jun 2016 15:26:47 +0200 | Subject | Re: [PATCH 3/3] iio: st_sensors: Use level interrupts |
| |
On Fri, May 13, 2016 at 8:43 PM, Crestez Dan Leonard <leonard.crestez@intel.com> wrote:
> As far as I can tell DRDY for ST sensors behaves as a level rather than > edge interrupt. Registering for IRQF_TRIGGER_RISING instead of > IRQF_TRIGGER_HIGH mostly works except when the sampling frequency is > high enough that new samples come before the new ones are read > completely. In that case the interrupt line remains high, no more rising > edges occur and the iio buffer stalls. > > Configuring the interrupt as IRQF_TRIGGER_HIGH makes it work as > expected. This patch makes it so that st_sensors_trigger interrupt > request code doesn't mangle the request flags into IRQF_TRIGGER_RISING. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Giuseppe Barba <giuseppe.barba@st.com> > Cc: Denis Ciocca <denis.ciocca@st.com> > Signed-off-by: Crestez Dan Leonard <leonard.crestez@intel.com> > --- > This is an alternative fix to this patch: > https://www.spinics.net/lists/linux-iio/msg24722.html > [PATCH 2/2 v6] iio: st_sensors: read surplus samples in trigger.
I have incorporated this approach into my patch now: please give it a spin!
Yours, Linus Walleij
| |