lkml.org 
[lkml]   [2016]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3.16 106/217] sd: disable discard_zeroes_data for UNMAP
From
Date


On 29/04/2016 06:00, Rafael David Tinoco wrote:
> Actually, It was an objection.
>
> Knowing that WRITESAME(16), used as the discard mechanism, can cause
> storage servers to misbehave (like QEMU's SCSI WRITESAME
> implementation, workaround-ed by commit e461338b6cd4) and those
> storage servers can't rely on LBPRZ flag to opt out from WRITESAME as
> discard mechanism (like QEMU does) since it is out of spec...

I think e461338b6cd4 is a perfectly fine change---independent of whether
it's a workaround for QEMU---and should be backported to stable kernels too.

Is there a reason to use WRITE SAME if LBPRZ=0? You risk doing a real
write which breaks thin provisioning and will probably take a huge time too.

Paolo

\
 
 \ /
  Last update: 2016-05-09 16:41    [W:0.120 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site