lkml.org 
[lkml]   [2016]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain
On Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang wrote:
> There's no need for dwarf support when perf recording with callchain.
>
> Signed-off-by: He Kuang <hekuang@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
> tools/perf/util/util.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index b7766c5..e5ebfd4 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
> "needed for --call-graph fp\n");
> break;
>
> -#ifdef HAVE_DWARF_UNWIND_SUPPORT
> /* Dwarf style */
> } else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
> const unsigned long default_stack_dump_size = 8192;
> @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
> ret = get_stack_size(tok, &size);
> param->dump_size = size;
> }
> -#endif /* HAVE_DWARF_UNWIND_SUPPORT */
> } else if (!strncmp(name, "lbr", sizeof("lbr"))) {
> if (!strtok_r(NULL, ",", &saveptr)) {
> param->record_mode = CALLCHAIN_LBR;
> --
> 1.8.5.2
>

\
 
 \ /
  Last update: 2016-05-07 20:21    [W:0.104 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site