lkml.org 
[lkml]   [2016]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH perf/core v9 00/16] perf-probe --cache and SDT support
Hi Masami,

On Sun, May 29, 2016 at 12:15:01AM +0900, Masami Hiramatsu wrote:
> Hi,
>
> Here is the 9th version of the patchset for probe-cache and
> initial SDT support.
>
> The previous version is here; https://lkml.org/lkml/2016/5/14/107
>
> This version just fixes 2 points according to Hemant's comment,
> and split out the filename__readable() patch.
>
> Changes in v9:
> - [1/16,2/16] split out the filename__readable()
> - [7/16] Fix to show which event is deleted.
> - [12/16] Update list_usage to show sdt option.
>
> Thank you,

Thanks for doing this, I hope this gets merged soon. The patch 4 and
14 look a bit larger and would be better to be splitted IMHO. Other
than that, all look good to me.

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>
> ---
>
> Hemant Kumar (1):
> perf/sdt: ELF support for SDT
>
> Masami Hiramatsu (15):
> perf-symbol: Introduce filename__readable to check readability
> perf symbol: Cleanup the code flow of dso__find_kallsyms
> perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
> perf probe: Add --cache option to cache the probe definitions
> perf probe: Use cache entry if possible
> perf probe: Show all cached probes
> perf probe: Remove caches when --cache is given
> perf probe: Add group name support
> perf buildid-cache: Scan and import user SDT events to probe cache
> perf probe: Accept %sdt and %cached event name
> perf-list: Show SDT and pre-cached events
> perf-list: Skip SDTs placed in invalid binaries
> perf probe: Allow wildcard for cached events
> perf probe: Support @BUILDID or @FILE suffix for SDT events
> perf probe: Support a special SDT probe format
>
>
> tools/perf/Documentation/perf-probe.txt | 26 +-
> tools/perf/builtin-list.c | 6
> tools/perf/builtin-probe.c | 30 ++
> tools/perf/util/build-id.c | 295 ++++++++++++++++--
> tools/perf/util/build-id.h | 8
> tools/perf/util/dso.h | 5
> tools/perf/util/parse-events.c | 83 +++++
> tools/perf/util/parse-events.h | 2
> tools/perf/util/probe-event.c | 492 +++++++++++++++++++++++++++---
> tools/perf/util/probe-event.h | 7
> tools/perf/util/probe-file.c | 504 +++++++++++++++++++++++++++++++
> tools/perf/util/probe-file.h | 41 +++
> tools/perf/util/symbol-elf.c | 252 ++++++++++++++++
> tools/perf/util/symbol.c | 71 ++--
> tools/perf/util/symbol.h | 22 +
> 15 files changed, 1712 insertions(+), 132 deletions(-)
>
> --
> Masami Hiramatsu

\
 
 \ /
  Last update: 2016-05-30 06:41    [W:0.165 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site