lkml.org 
[lkml]   [2016]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()
Date

Hi Vinod

> > > > Current rcar_dmac_desc_put() is using list_add_tail() in order to
> > > > push used descriptor to list of free descriptors, and next DMA transfer
> > > > try to reuse it from this list. But because it is using *_tail(),
> > > > this reuse effect can't be obtained without using all of them.
> > > > For a longer-term solution, we should allocate hardware descriptors
> > > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> > > > This patch uses list_add() instead of list_add_tail() for short-term
> > > > solution.
> > >
> > > Applied, thanks
> >
> > Thanks, but where did you apply it to ? I can't find it in your tree.
>
> I changed my mind after this and felt that we should document above
> in the changelog as well and replied to Kuninori few moments after this [1]
>
> Sorry if that wasn't clear that am not applying this.
>
> Please resend it with update changelog
>
> [1]: http://www.spinics.net/lists/dmaengine/msg09585.html

OK, will do

Best regards
---
Kuninori Morimoto

\
 
 \ /
  Last update: 2016-05-30 03:01    [W:0.064 / U:1.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site