lkml.org 
[lkml]   [2016]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: brcmnand: Add v7.2 controller support
Hello,

On Fri, 27 May 2016 14:58:11 -0700, Florian Fainelli wrote:

> + if (ctrl->nand_version >= 0x0702)
> + bits = 7;
> if (ctrl->nand_version >= 0x0600)

Don't you want an "else if" here ?

Otherwise, even for the 7.2 version of your controller bits will be set
to 1.

Ditto when setting ctrl->max_oob.

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2016-05-28 20:21    [W:0.030 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site