Messages in this thread | | | Date | Thu, 26 May 2016 11:00:55 +0200 | Subject | Re: [PATCH RFT 1/2] phylib: add device reset GPIO support | From | Linus Walleij <> |
| |
On Thu, May 12, 2016 at 8:42 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> [added Linus Walleij to Cc, there is a question for you/him below] (...) >> +void mdio_device_reset(struct mdio_device *mdiodev, int value) >> +{ >> + if (mdiodev->reset) >> + gpiod_set_value(mdiodev->reset, value); > > Before v4.6-rc1~108^2~91 it was not necessary to check for the first > parameter being non-NULL before calling gpiod_set_value. Linus, did you > change this on purpose?
Not really. And AFAICT it is still not necessary: what changed is that an error message will be printed by VALIDATE_DESC() if you do that. And that is proper I guess? I think it's sloppy code to randomly pass in NULL to a call and just expect it to bail out, it seems more like exercising the error path than something you'd normally rely on.
Or am I getting things wrong?
Yours, Linus Walleij
| |