lkml.org 
[lkml]   [2016]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] dell-wmi: Ignore WMI event code 0xe045
    Date
    From Dell we know that WMI event code 0xe045 is for Num Lock key, but it is
    unclear due to message in commit 0b3f6109f0c9 ("dell-wmi: new driver for
    hotkey control").

    Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
    Cc: Matthew Garrett <mjg@redhat.com>
    Cc: Mario Limonciello <mario_limonciello@dell.com>
    Link: https://lkml.org/lkml/2015/7/7/830
    ---
    drivers/platform/x86/dell-wmi.c | 13 ++++++++++++-
    1 file changed, 12 insertions(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
    index 15c6f11..4d23c91 100644
    --- a/drivers/platform/x86/dell-wmi.c
    +++ b/drivers/platform/x86/dell-wmi.c
    @@ -88,7 +88,6 @@ static const struct dmi_system_id dell_wmi_smbios_list[] __initconst = {
    static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
    { KE_IGNORE, 0x003a, { KEY_CAPSLOCK } },

    - { KE_KEY, 0xe045, { KEY_PROG1 } },
    { KE_KEY, 0xe009, { KEY_EJECTCD } },

    /* These also contain the brightness level at offset 6 */
    @@ -130,7 +129,19 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
    { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
    { KE_IGNORE, 0xe034, { KEY_KBDILLUMDOWN } },
    { KE_IGNORE, 0xe03a, { KEY_CAPSLOCK } },
    +
    + /*
    + * This entry is very suspicious!
    + * Originally Matthew Garrett created this dell-wmi driver specially for
    + * "button with a picture of a battery" which has event code 0xe045.
    + * Later Mario Limonciello from Dell told us that event code 0xe045 is
    + * reported by Num Lock and should be ignored because key is send also
    + * by keyboard controller.
    + * So for now we will ignore this event to prevent potential double
    + * Num Lock key press.
    + */
    { KE_IGNORE, 0xe045, { KEY_NUMLOCK } },
    +
    { KE_IGNORE, 0xe046, { KEY_SCROLLLOCK } },
    { KE_IGNORE, 0xe0f7, { KEY_MUTE } },
    { KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } },
    --
    1.7.9.5
    \
     
     \ /
      Last update: 2016-05-22 14:01    [W:2.884 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site