Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 23 May 2016 12:03:58 +0900 | From | Minchan Kim <> | Subject | Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info |
| |
On Thu, May 19, 2016 at 11:18:43AM -0400, Dan Streetman wrote: > Change the return type of zs_pool_stat_create() to void, and > remove the logic to abort pool creation if the stat debugfs > dir/file could not be created. > > The debugfs stat file is for debugging/information only, and doesn't > affect operation of zsmalloc; there is no reason to abort creating > the pool if the stat file can't be created. This was seen with > zswap, which used the same name for all pool creations, which caused > zsmalloc to fail to create a second pool for zswap if > CONFIG_ZSMALLOC_STAT was enabled. > > Signed-off-by: Dan Streetman <ddstreet@ieee.org> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Cc: Dan Streetman <dan.streetman@canonical.com> > Cc: Minchan Kim <minchan@kernel.org> Acked-by: Minchan Kim <minchan@kernel.org>
However, Andrew already sent old version to upstream.
Andrew, Could you send revert patch of [1] in linus's tree and send this instead of it if you have chance?
[1] d34f615720d1 mm/zsmalloc: don't fail if can't create debugfs info
Thanks.
| ![\](/images/icornerr.gif) |