lkml.org 
[lkml]   [2016]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt
Date
I've noticed crashes when using my x60t using a coreboot bios. When using
the pen I can produce a crash simply by tapping a few times. This
generates an event which has an idx of 0xc. This in turn crashes the
machine because the array access is greater than W8001_MAX_LENGTH. This
patch checks for bogus values and filters them in order to prevent crashes.

Signed-off-by: Chris J Arges <christopherarges@gmail.com>
---
drivers/input/touchscreen/wacom_w8001.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c
index bab3c6a..c858200 100644
--- a/drivers/input/touchscreen/wacom_w8001.c
+++ b/drivers/input/touchscreen/wacom_w8001.c
@@ -283,6 +283,15 @@ static irqreturn_t w8001_interrupt(struct serio *serio,
unsigned char tmp;

w8001->data[w8001->idx] = data;
+
+ /* ignore bogus idx values */
+ if (w8001->idx >= W8001_MAX_LENGTH) {
+ pr_info("w8001: ignored interrupt: data 0x%02x idx %d\n", data,
+ w8001->idx);
+ w8001->idx = 0;
+ return IRQ_HANDLED;
+ }
+
switch (w8001->idx++) {
case 0:
if ((data & W8001_LEAD_MASK) != W8001_LEAD_BYTE) {
--
2.7.4
\
 
 \ /
  Last update: 2016-05-23 04:01    [W:0.065 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site