Messages in this thread | | | Date | Mon, 2 May 2016 10:11:13 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] cpu/hotplug: handle unbalanced hotplug enable/disable |
| |
On Fri, 29 Apr 2016, Lianwei Wang wrote: > On Thu, Apr 28, 2016 at 5:44 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > > Wrong. This is the symptom. The root cause is in #1. Therefor you are trying > > to fix the symptom and not the root cause > > > I don't understand why you keep saying that the issue is in the pm > notifier callback. As I told you, the pm notifier return an error(or > NOTIFY_BAD) on purpose to abort the suspend process. This is work as > design. Any driver can abort the suspend process if it is not ready to > suspend.
Right. That's not the issue. The issue is that as a consequence we end up with an unbalanced count. So how do we end up with an unbalanced count? That's what needs to be fixed and not worked around.
> > I completely understand that you are tyring to put the cart before the horse. > No. Your understanding is wrong.
My understanding is very correct. We have a situation which leads to an unbalanced count. Instead of fixing that, you fix up the unbalanced count.
Thanks,
tglx
| |