Messages in this thread | | | Date | Mon, 2 May 2016 09:42:35 +0200 | From | Wolfram Sang <> | Subject | Re: [RESEND PATCH v2 00/13] eeprom: support for at24cs and at24mac |
| |
> The read and write routines are quite complex and decide which > operations to use (smbus or i2c) on the fly every time they're called. > Why not split them into several simpler functions (each implementing a > single way of talking to EEPROM) that would be assigned in probe() > depending on the chip type and adapter's functionalities? Would you be > willing to accept a series that does it?
That sounds like an interesting idea, in deed. I can't promise accepting it yet obviously, because I haven't seen any code yet. But I think it is worth pursuing. Maybe you could start hacking and keep going as long as you think it is an improvement to the driver?
Thanks,
Wolfram
[unhandled content-type:application/pgp-signature]
| |