lkml.org 
[lkml]   [2016]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 015/163] usb: hcd: out of bounds access in for_each_companion
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Robert Dobrowolski <robert.dobrowolski@linux.intel.com>

    commit e86103a75705c7c530768f4ffaba74cf382910f2 upstream.

    On BXT platform Host Controller and Device Controller figure as
    same PCI device but with different device function. HCD should
    not pass data to Device Controller but only to Host Controllers.
    Checking if companion device is Host Controller, otherwise skip.

    Signed-off-by: Robert Dobrowolski <robert.dobrowolski@linux.intel.com>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/core/hcd-pci.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    --- a/drivers/usb/core/hcd-pci.c
    +++ b/drivers/usb/core/hcd-pci.c
    @@ -74,6 +74,15 @@ static void for_each_companion(struct pc
    if (companion->bus != pdev->bus ||
    PCI_SLOT(companion->devfn) != slot)
    continue;
    +
    + /*
    + * Companion device should be either UHCI,OHCI or EHCI host
    + * controller, otherwise skip.
    + */
    + if (companion->class != CL_UHCI && companion->class != CL_OHCI &&
    + companion->class != CL_EHCI)
    + continue;
    +
    companion_hcd = pci_get_drvdata(companion);
    if (!companion_hcd || !companion_hcd->self.root_hub)
    continue;

    \
     
     \ /
      Last update: 2016-05-03 02:41    [W:6.410 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site