Messages in this thread | | | Date | Mon, 2 May 2016 14:53:20 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] modpost: fix module autoloading for OF devices with generic compatible property |
| |
On Mon, 2 May 2016 17:35:39 +0200 Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Since the wildcard at the end of OF module aliases is gone, autoloading > of modules that don't match a device's last (most generic) compatible value > fails. > > For example the CODA960 VPU on i.MX6Q has the SoC specific compatible > "fsl,imx6q-vpu" and the generic compatible "cnm,coda960". Since the driver > currently only works with knowledge about the SoC specific integration, > it doesn't list "cnm,cod960" in the module device table. > This results in the device compatible > "of:NvpuT<NULL>Cfsl,imx6q-vpuCcnm,coda960" not matching the module alias > "of:N*T*Cfsl,imx6q-vpu" anymore, whereas before commit 2f632369ab79 > ("modpost: don't add a trailing wildcard for OF module aliases") it > matched the module alias "of:N*T*Cfsl,imx6q-vpu*". > > This patch adds two module aliases for each compatible, one without the > wildcard and one with "C*" appended. > > $ modinfo coda | grep imx6q > alias: of:N*T*Cfsl,imx6q-vpuC* > alias: of:N*T*Cfsl,imx6q-vpu
I added this:
Cc: <stable@vger.kernel.org> [4.5+]
| |