lkml.org 
[lkml]   [2016]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] watchdog: shwdt: Use setup_timer()
Hi Muhammed,

> The function setup_timer combines the initialization of a timer with
> the initialization of the timer's function and data fields.
> The multiline code for timer initialization is now replaced
> with function setup_timer.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/watchdog/shwdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/shwdt.c b/drivers/watchdog/shwdt.c
> index f908121..517a733 100644
> --- a/drivers/watchdog/shwdt.c
> +++ b/drivers/watchdog/shwdt.c
> @@ -275,9 +275,7 @@ static int sh_wdt_probe(struct platform_device *pdev)
> return rc;
> }
>
> - init_timer(&wdt->timer);
> - wdt->timer.function = sh_wdt_ping;
> - wdt->timer.data = (unsigned long)wdt;
> + setup_timer(&wdt->timer, sh_wdt_ping, (unsigned long)wdt);
> wdt->timer.expires = next_ping_period(clock_division_ratio);
>
> dev_info(&pdev->dev, "initialized.\n");
> --
> 1.9.1
>

This patch was added to linux-watchdog-next.

Kind Regards,
Wim.

\
 
 \ /
  Last update: 2016-05-14 21:01    [W:0.049 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site