lkml.org 
[lkml]   [2016]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Date
Neil Armstrong <narmstrong@baylibre.com> writes:

> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> Controller.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

[...]

> +static int meson_gxbb_reset_assert(struct reset_controller_dev *rcdev,
> + unsigned long id)
> +{
> + struct meson_gxbb_reset *data =
> + container_of(rcdev, struct meson_gxbb_reset, rcdev);
> + unsigned int bank = id / BITS_PER_REG;
> + unsigned int offset = id % BITS_PER_REG;
> + void *reg_addr = data->reg_base + (bank << 2);
> +
> + if (bank >= REG_COUNT)
> + return -EINVAL;
> +
> + writel(readl(reg_addr) | BIT(offset), reg_addr);

The spec lists these registers as 16-bit registers, so probably readw/writew
are more appropriate here.

> + return 0;
> +}
> +
> +static int meson_gxbb_reset_deassert(struct reset_controller_dev *rcdev,
> + unsigned long id)
> +{
> + struct meson_gxbb_reset *data =
> + container_of(rcdev, struct meson_gxbb_reset, rcdev);
> + unsigned int bank = id / BITS_PER_REG;
> + unsigned int offset = id % BITS_PER_REG;
> + void *reg_addr = data->reg_base + (bank << 2);
> +
> + if (bank >= REG_COUNT)
> + return -EINVAL;
> +
> + writel(readl(reg_addr) & ~BIT(offset), reg_addr);

and here.

> + return 0;
> +}

Kevin

\
 
 \ /
  Last update: 2016-05-14 17:21    [W:0.053 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site