lkml.org 
[lkml]   [2016]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 1/4] dt-bindings: bus: Add documentation for Tegra210 ACONNECT
    On Tue, May 10, 2016 at 12:35:37PM +0100, Jon Hunter wrote:
    > Add binding documentation for the Tegra ACONNECT bus that is part of the
    > Audio Processing Engine (APE) on Tegra210. The ACONNECT bus is used to
    > access devices within the APE subsystem. The APE is located in a
    > separate power domain and so accesses made to the ACONNECT require the
    > power domain to be enabled as well as some platform specific clocks.
    >
    > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
    > ---
    > .../bindings/bus/nvidia,tegra210-aconnect.txt | 45 ++++++++++++++++++++++
    > 1 file changed, 45 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt
    >
    > diff --git a/Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt b/Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt
    > new file mode 100644
    > index 000000000000..81668f588eca
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt
    > @@ -0,0 +1,45 @@
    > +NVIDIA Tegra ACONNECT Bus
    > +
    > +The Tegra ACONNECT bus is an AXI switch which is used to connnect various
    > +components inside the Audio Processing Engine (APE). All CPU accesses to
    > +the APE subsystem go through the ACONNECT via an APB to AXI wrapper.
    > +
    > +Required properties:
    > +- compatible: Must be "nvidia,tegra210-aconnect".
    > +- clocks: Must contain the entries for the APE clock (TEGRA210_CLK_APE),
    > + and APE interface clock (TEGRA210_CLK_APB2APE).
    > +- clock-names: Must contain the names "ape" and "apb2ape" for the corresponding
    > + 'clocks' entries.
    > +- power-domains: Must contain a phandle that points to the audio powergate
    > + (namely 'aud') for Tegra210.
    > +- #address-cells: The number of cells used to represent physical base addresses
    > + in the aconnect address space. Should be 2.
    > +- #size-cells: The number of cells used to represent the size of an address
    > + range in the aconnect address space. Should be 2.

    You forgot to update these. With that,

    Acked-by: Rob Herring <robh@kernel.org>

    Rob

    \
     
     \ /
      Last update: 2016-05-14 16:41    [W:9.795 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site