lkml.org 
[lkml]   [2016]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces
From
> +err_unset_mode:
> + /* Clean up the mode changes. */
> + do_each_subsys_mask(ss, ssid, updated_mask) {
> + struct kernfs_node *kn = cset->subsys[ssid]->cgroup->kn;
> +
> + kernfs_break_active_protection(kn);
> + cgroup_kn_set_mode(kn, mode[ssid]);
> + kernfs_unbreak_active_protection(kn);
> + } while_each_subsys_mask();

Sorry, I just realised this doesn't unlock all of the relevant locks
in the error path. I'll send an updated patch.

--
Aleksa Sarai (cyphar)
www.cyphar.com

\
 
 \ /
  Last update: 2016-05-01 16:01    [W:0.029 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site