Messages in this thread | | | Date | Thu, 28 Apr 2016 22:06:37 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] staging: wilc1000: fix double unlock |
| |
On Thu, Apr 14, 2016 at 08:48:48PM +0530, Sudip Mukherjee wrote: > The semaphore was being released twice, once at the beginning of the > thread and then again when the thread is about to close. > The semaphore is acquired immediately after creating the thread so we > should be releasing it when the thread ends. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > --- > drivers/staging/wilc1000/linux_wlan.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c > index a858552..5643a3d 100644 > --- a/drivers/staging/wilc1000/linux_wlan.c > +++ b/drivers/staging/wilc1000/linux_wlan.c > @@ -313,7 +313,6 @@ static int linux_wlan_txq_task(void *vp) > vif = netdev_priv(dev); > wl = vif->wilc; > > - up(&wl->txq_thread_started); > while (1) { > down(&wl->txq_event); >
Doesn't apply to my tree at all :(
| |