lkml.org 
[lkml]   [2016]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()
From
Date

Hi,

On Thursday 28 April 2016 09:57 PM, Wouter Verhelst wrote:
> On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote:
>> Hi,
>>
>> On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote:
>>> Thanks for the review.
>>>
>>> Atleast for ext4 this crash happens on a sys_umount() call, timing of
>>> which is not in control of block driver. Block driver cannot force the
>>> filesystems to be unmounted, and the file system does not expect
>>> buffers to get unmapped under it.
>> Yes the block driver can't force a clean umount.
>>
>>> Ext4 can be fixed with the this patch:
>>> http://www.spinics.net/lists/linux-ext4/msg51112.html
>>> It did not make to the kernel. It checks the state of the buffer head
>>> before committing.
>>>
>>> When we consider diskett/CD as user space thread that called NBD_DO_IT,
>>> this problem is analogous to changing disk with another or the same
>>> disk suddenly when the file system is still mounted.
>>>
>>> If we completely kill the block device we would loss some writes when
>>> same thread is reconnected.
>> I am not so sure about your exact use-case here.
>>
>> If the NBD_DO_IT thread returns I am considering the connection and
>> block device as dead and disconnected. Securing any data afterwards with
>> a new connection is potentially dangerous as it may be a different
>> server.
> Yes, from the kernel POV you're right.
>
> However, at some point I agreed with Paul (your predecessor) that when
> this happens due to an error condition (as opposed to it being due to an
> explicit disconnect), the kernel would block all reads from or writes to
> the device, and the client may try to reconnect *from the same
> PID* (i.e., it may not fork()). If that succeeds, the next NBD_DO_IT is
> assumed to be connected to the same server; if instead the process
> exits, then the block device is assumed to be dead, will be reset, and
> all pending reads or writes would error.
>
> In principle, this allows for a proper reconnect from userspace if it
> can be done. However, I'm not sure whether this ever worked well or
> whether it was documented, so it's probably fine if you think it should
> be replaced with something else.
>
> (obviously, userspace reconnecting the device to a different device is
> wrong and should not be done, but that's a case of "if you break it, you
> get to keep both pieces)
>
> At any rate, I think it makes sense for userspace to be given a chance
> to *attempt* to reconnect a device when the connection drops
> unexpectedly.

To summarize different options we have:

1. Wait for all the buffers to get cleaned:
a) ... at the time of disconnect:
Not possible, because we can neither force upper layers to do the required
(ext4 umount crash scenario), nor kill mapped buffers unconditionally.
b) ... after disconnect, fail next reconnect with EBUSY if bd_openers > 1:
This would prevent even harmless reconnects from same device along with
problematic different device reconnects.

2. Do not wait for all buffers to get cleaned:
a) This particular patch does this. Inconsistency with a different device
reconnect is its disadvantage.

We may want to give preference same device reconnects as it is not rare.

(For floppy/cdrom disk drivers also, changing disk with different disk in the
middle results in inconsistency, and they left this case as user responsibility
to not do it.)

-Ratna

\
 
 \ /
  Last update: 2016-04-28 21:01    [W:0.093 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site