Messages in this thread | ![/](/images/icornerl.gif) | | From | Arnd Bergmann <> | Subject | Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly | Date | Thu, 28 Apr 2016 11:38:47 +0200 |
| |
On Thursday 28 April 2016 11:08:41 Arnd Bergmann wrote: > I only see two of them anyway (dreamcast and sh03), so that should > be easy enough to do. For instance in arch/sh/boards/mach-sh03/rtc.c, > the sh03_time_init() function should register a platform driver, > whose probe function calls devm_rtc_device_register() to register > with the rtc subsystem. Then you move the entire file to drivers/rtc/ > and change the callers of sh03_time_init() to create the device > manually (for the classic board file) or drop it (for DT).
Just FYI:
Another look at the sh03_rtc_settimeofday function shows that it's always been wrong: unlike the set_mmss() function it calls, it should set all the time fields, not just minutes and seconds.
Arnd
| ![\](/images/icornerr.gif) |