lkml.org 
[lkml]   [2016]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm: panel: simple-panel: set appropriate mode type
From
Date
Le 28/05/2015 16:25, Boris Brezillon a écrit :
> Hi Thierry,
>
> Could you have a look at this patch (a.k.a. ping) ?

It's been a long time and... It seems that this patch doesn't apply
anymore but:

Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>

So, I'm updating it and resending right now.

Bye,

> On Thu, 30 Apr 2015 16:39:30 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
>> All modes exposed by simple panels should be tagged as driver defined
>> modes.
>> Moreover, if a panel supports only one mode, this mode is obviously the
>> preferred one.
>>
>> Doing this also fix a problem occurring when a 'video=' parameter is passed
>> on the kernel cmdline. In some cases the user provided mode is preferred
>> over the simple panel ones, which might result in unpredictable behavior.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> ---
>> drivers/gpu/drm/panel/panel-simple.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index d14b904..95ae390 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -111,6 +111,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
>> continue;
>> }
>>
>> + mode->type |= DRM_MODE_TYPE_DRIVER;
>> + if (panel->desc->num_modes == 1)
>> + mode->type |= DRM_MODE_TYPE_PREFERRED;
>> +
>> drm_display_mode_from_videomode(&vm, mode);
>>
>> drm_mode_probed_add(connector, mode);
>> @@ -127,6 +131,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
>> continue;
>> }
>>
>> + mode->type |= DRM_MODE_TYPE_DRIVER;
>> + if (panel->desc->num_modes == 1)
>> + mode->type |= DRM_MODE_TYPE_PREFERRED;
>> +
>> drm_mode_set_name(mode);
>>
>> drm_mode_probed_add(connector, mode);
>
>
>


--
Nicolas Ferre

\
 
 \ /
  Last update: 2016-04-15 18:21    [W:0.072 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site