Messages in this thread Patch in this message | | | Date | Wed, 9 Mar 2016 03:44:41 -0800 | From | tip-bot for Josh Poimboeuf <> | Subject | [tip:core/objtool] objtool: Remove superflous INIT_LIST_HEAD |
| |
Commit-ID: e2a5f18a1ba11e8b1e9ee53b6fca4be12bb5749e Gitweb: http://git.kernel.org/tip/e2a5f18a1ba11e8b1e9ee53b6fca4be12bb5749e Author: Josh Poimboeuf <jpoimboe@redhat.com> AuthorDate: Wed, 9 Mar 2016 00:06:56 -0600 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 9 Mar 2016 10:48:08 +0100
objtool: Remove superflous INIT_LIST_HEAD
The insns list is initialized twice, in cmd_check() and in decode_instructions(). Remove the latter.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@kernel.org> Cc: Arnaldo Carvalho de Melo <acme@infradead.org> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Bernd Petrovitsch <bernd@petrovitsch.priv.at> Cc: Borislav Petkov <bp@alien8.de> Cc: Chris J Arges <chris.j.arges@canonical.com> Cc: Jiri Slaby <jslaby@suse.cz> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Michal Marek <mmarek@suse.cz> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Pedro Alves <palves@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/be6e21d7eec1f072095d22a1cbe144057135e097.1457502970.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- tools/objtool/builtin-check.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c index 46a8985..a974f295 100644 --- a/tools/objtool/builtin-check.c +++ b/tools/objtool/builtin-check.c @@ -249,8 +249,6 @@ static int decode_instructions(struct objtool_file *file) struct instruction *insn; int ret; - INIT_LIST_HEAD(&file->insns); - list_for_each_entry(sec, &file->elf->sections, list) { if (!(sec->sh.sh_flags & SHF_EXECINSTR))
| |