Messages in this thread | | | Date | Tue, 8 Mar 2016 14:54:21 +0700 | From | Lee Jones <> | Subject | Re: [PATCH v1 1/1] mfd: intel-lpss: save register context on suspend |
| |
On Tue, 08 Mar 2016, Andy Shevchenko wrote:
> On Tue, Mar 8, 2016 at 6:48 AM, Lee Jones <lee.jones@linaro.org> wrote: > > On Tue, 26 Jan 2016, Andy Shevchenko wrote: > > > >> From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > >> > >> All configurations are lost and the registers will have > >> default values when the hardware is suspended and resumed, > >> so saving the private register space context on suspend, and > >> restoring it on resume. > >> > >> Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices) > > > > I'd say this sumbission is more of a functional extention than a > > bug-fix. No real need for this statement. > > But we would like send it later to stable@ to have this back ported.
Yes, I see.
Although, as it "fixes" a first submission, my personal preference would be a:
Cc: stable@vger.kernel.org # v4.{whatever}
.. tag instead.
> >> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > Did it really take 2 of you to write this patch? > > It's probably my mistake, since I took this one from Mika's tree and > kept his SoB.
No problem.
Please omit his SoB when upstreaming patches from BSP trees.
> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> --- > >> drivers/mfd/intel-lpss.c | 19 ++++++++++++++++++- > >> 1 file changed, 18 insertions(+), 1 deletion(-) > > > > Code looks okay though: > > Acked-by: Lee Jones <lee.jones@linaro.org> > > Thanks. >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |