lkml.org 
[lkml]   [2016]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback
On Tue, 8 Mar 2016 10:22:07 -0500 (EST)
Chunyu Hu <chuhu@redhat.com> wrote:


> Thanks for the quick review! This is an mistake, the change below should be after it. From my
> limited knowledge and observation, seems there is no tracer sharing the tracer_flag except the
> dummy_tracer flag. As in the patch that flag is not shared any more, so i also removed these check
> in the previous email.
>
>
> @@ -6390,15 +6400,6 @@ create_trace_option_files(struct trace_array *tr, struct tracer *tracer)
> if (!trace_ok_for_array(tracer, tr))
> return;
>
> - for (i = 0; i < tr->nr_topts; i++) {
> - /*
> - * Check if these flags have already been added.
> - * Some tracers share flags.
> - */
> - if (tr->topts[i].tracer->flags == tracer->flags)
> - return;
> - }
> -
>

The latency tracers share flags (irqsoff, preemptoff and preemptirqsoff)

-- Steve

\
 
 \ /
  Last update: 2016-03-08 17:21    [W:0.041 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site