Messages in this thread | | | Subject | Re: [PATCH 1/3] mm, compaction: change COMPACT_ constants into enum | From | Vlastimil Babka <> | Date | Tue, 8 Mar 2016 15:19:15 +0100 |
| |
On 03/08/2016 02:42 PM, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > compaction code is doing weird dances between > COMPACT_FOO -> int -> unsigned long > > but there doesn't seem to be any reason for that. All functions which
I vaguely recall trying this once and running into header dependency hell. But maybe it was something a bit different and involved storing a value in struct compact_control.
> return/use one of those constants are not expecting any other value > so it really makes sense to define an enum for them and make it clear > that no other values are expected. > > This is a pure cleanup and shouldn't introduce any functional changes. > > Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Thanks.
| |