Messages in this thread | | | Date | Tue, 8 Mar 2016 14:23:40 +0100 | From | Ingo Molnar <> | Subject | Re: [tip:perf/core] perf tools: Fix locale handling in pmu parsing |
| |
* tip-bot for Jiri Olsa <tipbot@zytor.com> wrote:
> @@ -135,6 +146,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char * > /* restore locale */ > setlocale(LC_NUMERIC, lc); > > + free((char *) lc); > +
Btw., minor side note: why does 'lc' have to be case to 'char *'?
In the kernel kfree() takes 'const void *':
include/linux/slab.h:void kfree(const void *);
which will accept all pointer types. That avoids unnecessary and fragile type casts.
Thanks,
Ingo
| |