Messages in this thread | | | From | Rob Herring <> | Date | Tue, 8 Mar 2016 02:49:27 -0600 | Subject | Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is used alone |
| |
On Mon, Mar 7, 2016 at 11:46 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > The compatible string "simple-bus" is well defined in ePAPR, while > I see no documentation for the "arm,amba-bus" in ePAPR or under > Documentation/devicetree/. > > DT is also used by other projects than Linux kernel. It is not a > good idea to rely on such an unofficial binding. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v2: > - Rephrase the git-log
[...]
> diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi > index ea288f0..8da4582 100644 > --- a/arch/arm/boot/dts/axm55xx.dtsi > +++ b/arch/arm/boot/dts/axm55xx.dtsi > @@ -107,7 +107,7 @@ > }; > > amba { > - compatible = "arm,amba-bus"; > + compatible = "arm,amba-bus", "simple-bus";
As I mentioned in the last version, I think you should remove arm,amba-bus and just have simple-bus. I don't believe anything relies on having arm,amba-bus.
Rob
| |