Messages in this thread | | | Date | Wed, 9 Mar 2016 09:55:44 +0700 | Subject | Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support | From | Linus Walleij <> |
| |
On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar <vishnupatekar0510@gmail.com> wrote:
> The A83T has R_PIO pin controller, it's same as A23, execpt A83T > interrupt bit is 6th and A83T has one extra pin PL12. > > Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com> > Acked-by: Chen-Yu Tsai <wens@csie.org> > Acked-by: Rob Herring <robh@kernel.org>
As partly noted by others:
> +config PINCTRL_SUN8I_A83T_R > + def_bool MACH_SUN8I
bool
> + depends on RESET_CONTROLLER
Should it rather select RESET_CONTROLLER?
> +static const struct of_device_id sun8i_a83t_r_pinctrl_match[] = { > + { .compatible = "allwinner,sun8i-a83t-r-pinctrl", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, sun8i_a83t_r_pinctrl_match);
Module talk in bool driver.
> +static struct platform_driver sun8i_a83t_r_pinctrl_driver = { > + .probe = sun8i_a83t_r_pinctrl_probe, > + .driver = { > + .name = "sun8i-a83t-r-pinctrl", > + .of_match_table = sun8i_a83t_r_pinctrl_match, > + }, > +}; > +module_platform_driver(sun8i_a83t_r_pinctrl_driver);
Should be builtin?
Yours, Linus Walleij
| |