Messages in this thread | | | Date | Mon, 7 Mar 2016 16:28:26 -0800 | Subject | Re: [PATCH net-next 2/3] ipv6: per netns fib6 walkers | From | Cong Wang <> |
| |
On Mon, Mar 7, 2016 at 4:26 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote: > On Fri, Mar 4, 2016 at 2:59 AM, Michal Kubecek <mkubecek@suse.cz> wrote: >> static void ipv6_route_seq_setup_walk(struct ipv6_route_iter *iter) >> { >> +#ifdef CONFIG_NET_NS >> + struct net *net = iter->p.net; >> +#else >> + struct net *net = &init_net; >> +#endif >> + > > You should pass the struct net pointer to ipv6_route_seq_setup_walk() > instead of reading it by yourself. > > I don't find anyone actually using iter->p, it probably can be just removed.
Er, seq_file_net() uses it... but callers already call it.
| |